Fix automation test #13213
Merged
Fix automation test #13213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infiloop2
reviewed
May 15, 2024
| @@ -1248,6 +1248,9 @@ func TestSetOffchainConfigWithMaxGasPrice(t *testing.T) { | |||
| require.NoError(t, err, "Error setting upkeep offchain config") | |||
| } | |||
|
|
|||
| // sleep for 10s to make sure any in-flight performs are done | |||
| time.Sleep(10 * time.Second) | |||
There was a problem hiding this comment.
is there a better way for performs to get done instead of hardocded time.sleep
There was a problem hiding this comment.
Do we have a number of performs we expect that we can wait for using gom.Eventually like above
There was a problem hiding this comment.
it's difficult to expect how many times it will perform so i use the n + 1 check from other tests to account for 1 possible in-flight request
anirudhwarrier
approved these changes
May 15, 2024
cmalec
approved these changes
May 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This was referenced May 15, 2024
infiloop2
pushed a commit
that referenced
this pull request
Jun 10, 2024
* fix automation test flake * add changeset * update * udpate * fix lint * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.